Template talk:Disambig

From Pin Eight
Jump to: navigation, search

Protocol-relative[edit]

{{sudo}}The URL for the action=edit link isn't currently protocol-relative. I suggest using {{fullurl:{{FULLPAGENAME}}|action=edit}} rather than manually typing the //pineight.com... part. If I understand correctly, this ensures that the domain name (www or no) will match what the reader is using and hence that the login session will be preserved correctly. --Eighty5cacao (talk) 04:14, 23 April 2013 (UTC)

View source and see that it already does use {{fullurl:{{FULLPAGENAME}}|action=edit}}. The fact that a protocol appears in the output of {{fullurl}} may come from the workaround that I have to do in LocalSettings.php to interoperate with WebFaction's front-end proxy, which maps HTTP on Internet-facing port 80 to HTTP on internal port 80 but maps HTTPS on Internet-facing port 443 to HTTP on an internal port. Should I make it a priority to try fixing {{fullurl}} in general? --Tepples (talk) 14:30, 23 April 2013 (UTC)
Sorry for not doing that ... I was unnecessarily reluctant to see the error message. I think this is another case of $wgServer needing to be manually set as protocol-relative, as I mentioned elsewhere. If this is not immediately practical, should we think about doing something similar to secure new.js (local "copy")? --Eighty5cacao (talk) 16:46, 23 April 2013 (UTC) (last edit 01:19, 24 April 2013 (UTC))
I ended up just forcing $wgServer to "//pineight.com" rather than trying to autodetect protocol. The problem may have come from old pre-1.18 code in my LocalSettings.php. --Tepples (talk) 01:39, 26 April 2013 (UTC)
Ok, it appears to be working on all the disambiguation pages where the template is used. --Eighty5cacao (talk) 03:31, 26 April 2013 (UTC)